Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mime attribute of enablepcmcontenttypemovie #1526

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Sep 11, 2023

Remove this attribute as it is not used.

b/216483296

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1526 (7653431) into main (b929b6f) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 7653431 differs from pull request most recent head 47d829a. Consider uploading reports for the commit 47d829a to get more accurate results

@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
+ Coverage   57.57%   57.59%   +0.01%     
==========================================
  Files        1905     1905              
  Lines       94729    94729              
==========================================
+ Hits        54544    54559      +15     
+ Misses      40185    40170      -15     

see 6 files with indirect coverage changes

Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests all pass, this looks clean to me.

@borongc borongc force-pushed the cleanup_pcm branch 3 times, most recently from 7653431 to 3dfcb1f Compare September 12, 2023 18:38
Remove this attribute as it is not used.

b/216483296
@borongc borongc merged commit d3f34bc into youtube:main Sep 12, 2023
341 of 342 checks passed
@borongc borongc deleted the cleanup_pcm branch September 12, 2023 20:36
@borongc borongc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Mar 2, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Mar 2, 2024
Remove this attribute as it is not used.

b/216483296

(cherry picked from commit d3f34bc)
borongc added a commit that referenced this pull request Mar 18, 2024
Remove this attribute as it is not used.

b/216483296

(cherry picked from commit d3f34bc)
borongc added a commit that referenced this pull request Mar 18, 2024
…ovie (#2532)

Refer to the original PR: #1526

Remove this attribute as it is not used.

b/216483296

---------

Co-authored-by: Bo-Rong Chen <borongchen@google.com>
borongc added a commit to borongc/cobalt that referenced this pull request Apr 9, 2024
Remove this attribute as it is not used.

b/216483296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants